fix: handle the file not found error gracefully #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please add a test for this case? |
golesuman
force-pushed
the
fix/file-not-found-error
branch
2 times, most recently
from
c1ed3ca
to
483b391
Compare
yeah done please check @aj3sh |
golesuman
changed the title
golesuman
force-pushed
the
fix/file-not-found-error
branch
from
483b391
to
e2db255
Compare
aj3sh
requested changes
May 24, 2024
golesuman
force-pushed
the
fix/file-not-found-error
branch
from
e2db255
to
b69726c
Compare
aj3sh
approved these changes
May 24, 2024
ghost
mentioned this pull request
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Give meaningful error message than giving the full stack trace when the file is not found.
Related Issue
Fixes: #44
Type of Change
Please mark the appropriate option below to describe the type of change your pull request introduces:
Checklist
Examples:
"fix: Fixed foobar bug","feat(accounts): Added foobar feature".README.md.Additional Notes
[Add any additional notes or context that you think the reviewers should know about.]
By submitting this pull request, I confirm that I have read and complied with the contribution guidelines of this project.