Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support pull_request_target events #52

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

kadams54
Copy link
Contributor

@kadams54 kadams54 commented Jul 1, 2024

Description

pull_request events don't have the necessary privileges to access private repos. Adding support for the pull_request_target event will allow private repos to also use commit lint.

Related Issue

[If your pull request is related to an existing issue, reference it here using the format "Fixes #issue_number".]

Type of Change

Please mark the appropriate option below to describe the type of change your pull request introduces:

  • Bug fix
  • New feature
  • Enhancement
  • Documentation update
  • Refactor
  • Other (please specify)

Checklist

  • My pull request has a clear title and description.
  • I have used semantic commit messages.
    Examples: "fix: Fixed foobar bug", "feat(accounts): Added foobar feature".
  • I have added/updated the necessary documentation on README.md.
  • I have added appropriate test cases (if applicable) to ensure the changes are functioning correctly.

Additional Notes

[Add any additional notes or context that you think the reviewers should know about.]

By submitting this pull request, I confirm that I have read and complied with the contribution guidelines of this project.

@aj3sh
Copy link
Member

aj3sh commented Jul 1, 2024

Hi @kadams54, Thank you for contributing and adding a new feature in the commitlint. We will quickly review the code and the pull_request_target event details.
This is a must-have feature that we have missed.

@aj3sh aj3sh self-assigned this Jul 1, 2024
aj3sh
aj3sh previously approved these changes Jul 1, 2024
Copy link
Member

@aj3sh aj3sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good.

@aj3sh aj3sh requested a review from sugat009 July 1, 2024 15:16
@aj3sh aj3sh assigned sugat009 and unassigned aj3sh Jul 1, 2024
@aj3sh aj3sh added the enhancement New feature or request label Jul 1, 2024
`pull_request` events don't have the necessary privileges to access
private repos. Adding support for the `pull_request_target` event will
allow private repos to also use commit lint.
Copy link
Contributor

@sugat009 sugat009 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kadams54 Thanks for your contribution. I've left a suggestion on the changes.

github_actions/run.py Outdated Show resolved Hide resolved
Co-authored-by: Sugat Bajracharya <30311933+sugat009@users.noreply.github.com>
@aj3sh aj3sh merged commit 62e1128 into opensource-nepal:main Jul 2, 2024
3 checks passed
@github-actions github-actions bot mentioned this pull request Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants