Move plugins to own repo

[rehammuzzamil]

Resolves opensrp/fhircore#2213 and resolves #5

[dubdabasoduba]

@rehammuzzamil can we remove the Google specific plugins and only keeps the OpenSRP ones

[rehammuzzamil]

@rehammuzzamil can we remove the Google specific plugins and only keeps the OpenSRP ones

Sure, but I believe there are still certain classes that would be duplicated for example some helper classes.

[ndegwamartin]

@rehammuzzamil for helper classes we may be using that are not part of the plugins package feel free to change their visibility e.g. make methods public and we can make that as a contribution back to Google

[ndegwamartin]

@rehammuzzamil we can add some documentation on the main README.md file with overview on this project since it's an open source project.

See these links for samples:

• https://github.com/opensrp/opensrp-client-unicef-tunisia
• https://github.com/opensrp/opensrp-client-core

[ndegwamartin]

Please include the changes in these commits :

• opensrp/fhir-gateway@0096735

• opensrp/fhir-gateway@7df1481

[pld]

Let's configure spotless to handle thisOn Oct 3, 2023, at 14:08, Martin Ndegwa ***@***.***> wrote: @ndegwamartin commented on this pull request. In customplugins/src/main/java/org/smartregister/fhir/gateway/plugins/PermissionAccessChecker.java:

import com.google.gson.JsonObject;

import java.util.*; import java.util.stream.Collectors; import javax.inject.Named; +import org.apache.commons.lang3.StringUtils; import org.hl7.fhir.r4.model.*; Ditto —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[ndegwamartin]

Actually on further review I've noticed there's a lot of important changes that are in the PR here opensrp/fhir-gateway#45 and my not be part of this PR e.g. the changes in the code block here https://github.com/opensrp/fhir-gateway/pull/45/files#diff-97e5f04f911ea8b59eb9a66205ba40363d78acb788a1eb396e3e827b4fb94d9aR353-R359

Please review the PR again and incorporate all the (relevant) changes. Pick them manually, cherry picking with Git will not work.

[rehammuzzamil]

Actually on further review I've noticed there's a lot of important changes that are in the PR here opensrp/fhir-gateway#45 and my not be part of this PR e.g. the changes in the code block here https://github.com/opensrp/fhir-gateway/pull/45/files#diff-97e5f04f911ea8b59eb9a66205ba40363d78acb788a1eb396e3e827b4fb94d9aR353-R359

Please review the PR again and incorporate all the (relevant) changes. Pick them manually, cherry picking with Git will not work.

Noted, let me review it. Thanks

[ndegwamartin]

@rehammuzzamil for now lets also remove all the licenses since the repo/codebase is private cc @pld

[rehammuzzamil]

Actually on further review I've noticed there's a lot of important changes that are in the PR here opensrp/fhir-gateway#45 and my not be part of this PR e.g. the changes in the code block here https://github.com/opensrp/fhir-gateway/pull/45/files#diff-97e5f04f911ea8b59eb9a66205ba40363d78acb788a1eb396e3e827b4fb94d9aR353-R359

Please review the PR again and incorporate all the (relevant) changes. Pick them manually, cherry picking with Git will not work.

Done

[ndegwamartin]

@rehammuzzamil not sure you pushed your changes??

I still see this commit (among others) still missing.

https://github.com/opensrp/fhir-gateway/pull/45/files#diff-97e5f04f911ea8b59eb9a66205ba40363d78acb788a1eb396e3e827b4fb94d9aR353-R359

Perhaps we can pair so that we are aligned.

[rehammuzzamil]

@rehammuzzamil not sure you pushed your changes??

I still see this commit (among others) still missing.

https://github.com/opensrp/fhir-gateway/pull/45/files#diff-97e5f04f911ea8b59eb9a66205ba40363d78acb788a1eb396e3e827b4fb94d9aR353-R359

Perhaps we can pair so that we are aligned.

@ndegwamartin
I have manually copied and updated the changes from the same PR you have mentioned, used diffchecker utility to verify the changes just to be sure, however, let me recheck again.
May be there are still some commits left on my local branch.

Thanks!