P2P - Implement Error Handling class

[f-odhiambo]

Manage any errors brought about by

1. Loss Network connectivity
2. Failed sync operation
3. Unauthorised sync
4. Missing fields
5. Invalid data types/formats
6. Failed updated during PATCH

And report back either error message or/and status code

[Rkareko]

@f-odhiambo @dubdabasoduba could you give further information on what is required for this ticket.

[dubdabasoduba]

@Rkareko @ekigamba I think we need the following

• Gracefully handle all the errors that might occur in the whole P2P process i.e during discovery, paring and data transfer.
• Provide the appropriate messages in case fatal errors occur.
• Provide the correct informational messages in case the following things are not available.
  • WifI is not turned on
  • Wifi is connected to a network
  • Wifidirect is not enabled.
• Could we update the main P2P page to show the requirements instructions for the users? @HenryRae any thoughts?

[pld]

Are these errors getting thrown by / is this an issue with fhircore or is it with the p2p library?

It might be reasonable for the p2p library to catch any exception the code it raises and throw it's own exception with error messaging, then fhircore can only concern itself with catching the p2p exception

[Rkareko]

@Rkareko @ekigamba I think we need the following

• Gracefully handle all the errors that might occur in the whole P2P process i.e during discovery, paring and data transfer.

• Provide the appropriate messages in case fatal errors occur.

• Provide the correct informational messages in case the following things are not available.

  • WifI is not turned on
  • Wifi is connected to a network
  • Wifidirect is not enabled.

• Could we update the main P2P page to show the requirements instructions for the users? @HenryRae any thoughts?

@dubdabasoduba thoughts on gracefully handling errors : -

1. On activity.onPause call diconnect() if already connected. This will disconnect wifi-direct.
2. Show error message toast / notification
3. Exit P2P activity so that resources are cleaned up

[Rkareko]

@Rkareko @ekigamba I think we need the following

• Gracefully handle all the errors that might occur in the whole P2P process i.e during discovery, paring and data transfer.

• Provide the appropriate messages in case fatal errors occur.

• Provide the correct informational messages in case the following things are not available.

  • WifI is not turned on
  • Wifi is connected to a network
  • Wifidirect is not enabled.

• Could we update the main P2P page to show the requirements instructions for the users? @HenryRae any thoughts?

@dubdabasoduba thoughts on gracefully handling errors : -

1. On activity.onPause call diconnect() if already connected. This will disconnect wifi-direct.
2. Show error message toast / notification
3. Exit P2P activity so that resources are cleaned up

Sub tasks

• Detect whether Wifi is turned on #33
• Handle failures in WifiDirectDataSharingStrategy class #30

[Rkareko]

• Provide the appropriate messages in case fatal errors occur.

@dubdabasoduba could you provide further clarification on this point. When fatal errors occur that would mean the app has already crashed.

[Rkareko]

• Could we update the main P2P page to show the requirements instructions for the users? @HenryRae any thoughts?

@dubdabasoduba @HenryRae please provide designs / way forward on how to implement this.

[pld]

replace w/new issue after discussion