Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[P2P] - Sync bugs on latest release v.0.0.6 #1280

Closed
1 task
AnnieMungai opened this issue May 16, 2022 · 8 comments · May be fixed by onaio/android-p2p#50
Closed
1 task

[P2P] - Sync bugs on latest release v.0.0.6 #1280

AnnieMungai opened this issue May 16, 2022 · 8 comments · May be fixed by onaio/android-p2p#50
Assignees
Labels
eCBIS The FHIR Last Mile Health Project P2P Sync

Comments

@AnnieMungai
Copy link
Contributor

AnnieMungai commented May 16, 2022

Describe the bug
A clear and concise description of what the bug is.

  • P2P sync not functioning properly. The device gets stuck at scanning for the available devices.
    IMG20220516112930
  • [ ] Sync taking 7 minutes to complete.
@AnnieMungai AnnieMungai changed the title eCBIS eCBIS v.0.0.6 bugs May 16, 2022
@f-odhiambo f-odhiambo added P2P Sync eCBIS The FHIR Last Mile Health Project labels May 16, 2022
@AnnieMungai
Copy link
Contributor Author

AnnieMungai commented May 16, 2022

@dubdabasoduba here is an update on P2P. Following the steps for connection, I was able to connect the 2 devices but they forced closed during the data transfer. The process was not successful.

@f-odhiambo f-odhiambo changed the title eCBIS v.0.0.6 bugs [eCBIS] - P2P Sync bugs on latest release v.0.0.6 May 16, 2022
@dubdabasoduba
Copy link
Member

WhatsApp.Video.2022-05-16.at.2.57.04.PM.mp4

@dubdabasoduba
Copy link
Member

@Rkareko @ekigamba Here are my initial thoughts on the issues.

  1. Can we close the connection when our app force closes? WifiDirect will create a group when pairing is done. Does the android OS allow us to delete this group if the process exits successfully or due to an error?
    • I think this will help with the issue where both devices are waiting for fr data transfer instead of trying to establish a connection first.
    • We need to check the force close to gracefully handle fatal errors. We could redirect to the main P2P page in case the process has a fatal error.

@ekigamba
Copy link
Contributor

@dubdabasoduba I agree.We'll need to replicate this to fix the specific issue.

We are going to handle some of these issues here onaio/android-p2p#30 as part of Phase II. We handled some of these issues below 😞

@ekigamba
Copy link
Contributor

ekigamba commented May 17, 2022

@AnnieMungai When you talk about sync above, is it the device-to-server sync or p2p sync?

@AnnieMungai
Copy link
Contributor Author

@ekigamba its server >> device sync.

@ekigamba
Copy link
Contributor

Thanks @AnnieMungai for the clarification.

cc @dubdabasoduba

@pld
Copy link
Member

pld commented May 17, 2022

OK server-device will be addressed by other sync work @roywanyaga is involved, I'll update the description to reflect this issue is only about the p2p part

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
eCBIS The FHIR Last Mile Health Project P2P Sync
Development

Successfully merging a pull request may close this issue.

7 participants