Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added button text field to change the optibp button text #615

Merged
merged 4 commits into from
Jan 10, 2022

Conversation

junaidwarsivd
Copy link
Contributor

related issue #614

@junaidwarsivd junaidwarsivd changed the base branch from master to develop January 7, 2022 13:21
@junaidwarsivd junaidwarsivd changed the base branch from develop to master January 7, 2022 13:24
@SebaMutuku
Copy link
Contributor

@ndegwamartin would you mind having a look at this?

Copy link
Contributor

@SebaMutuku SebaMutuku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bennsimon would you mind having a look at this?

@@ -164,6 +164,12 @@ private void formatButtonWidget(Button button, JSONObject jsonObject) throws JSO
String colorString = jsonObject.getString(JsonFormConstants.OptibpConstants.OPTIBP_KEY_BUTTON_TEXT_COLOR);
button.setTextColor(Color.parseColor(colorString));
}
if(jsonObject.has(JsonFormConstants.OptibpConstants.OPTIBP_KEY_BUTTON_TEXT))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Format this section
if(jsonObject.has(JsonFormConstants.OptibpConstants.OPTIBP_KEY_BUTTON_TEXT))
{
String buttonText = jsonObject.getString(JsonFormConstants.OptibpConstants.OPTIBP_KEY_BUTTON_TEXT);
button.setText(buttonText);
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SebaMutuku SebaMutuku merged commit 0307657 into master Jan 10, 2022
@SebaMutuku SebaMutuku deleted the optibp_button_text_addition branch January 10, 2022 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No field to change the optibp button text in optibp widget factory
2 participants