Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ensureSecret and use one from lib-common #198

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove ensureSecret and use one from lib-common #198

wants to merge 1 commit into from

Conversation

mrkisaolamb
Copy link
Contributor

@openshift-ci openshift-ci bot requested review from kk7ds and olliewalsh May 20, 2024 15:17
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrkisaolamb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mrkisaolamb mrkisaolamb linked an issue May 20, 2024 that may be closed by this pull request
Move ensureSecret to lib-common and use it in placement #133
Open
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 20, 2024

@mrkisaolamb: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/functional 331502c link true /test functional
ci/prow/precommit-check 331502c link true /test precommit-check
ci/prow/placement-operator-build-deploy-kuttl 331502c link true /test placement-operator-build-deploy-kuttl

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kk7ds kk7ds Awaiting requested review from kk7ds

@olliewalsh olliewalsh Awaiting requested review from olliewalsh

Assignees
No one assigned
Labels
approved needs-rebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move ensureSecret to lib-common and use it in placement
2 participants
@mrkisaolamb @openshift-merge-robot