-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing Mapillary images #2794
Comments
It appears that only the first image of a sequence of images is displayed. |
After thought about this, it's a fundamental problem with their API (https://github.com/mapillary/mapillary_issues/issues/1264#issuecomment-145145129) where a request for a small bbox with a few pictures returns 357KB GeoJSON listing 5.7k images. @gyllen, any eta on API changes? |
A lot is moving in #2720, so I wouldn't worry about this too much. I am changing the Mapillary service to cache whatever data we request, and make it async, and break it up by actual tiles (instead of just requesting everything in the viewport bbox on every redraw event). Basically, make it work more like how we request data from the OSM API. The original Mapillary implementation was done kind of hastily, and now the streetsigns effort ended up just a copy of that, so I think we're at the point where we need to do better. And if I get this right, it paves the way for people to build other services that can be put into the Map Data panel and displayed as a data overlay (OSM Notes and QA tool results like KeepRight are two that could follow quickly). I'm also probably going to replace the sequences api call with the one that just fetches all images - we don't have forward/backward buttons and just display everything anyway so sequences are kind of meaningless in this context. Like you said, I think the sequences api call misses a lot of images. |
When I debugged the results, the Mapillary API returned a list of all the images, but something later on choked on 5k images. |
I'm planning to use |
Any progress on this? I was not able to pinpoint the bottleneck, that's why I limited the amount of shown hits form Mapillary. |
It doesn't work here: |
The code hasn't yet been merged to master.. |
I have just discovered this problem, using ID with Mapillary for the first time. |
If I look at http://www.openstreetmap.org/edit?editor=id#map=17/48.38357/-122.33288, I see a limited number of tracks on the I 5. Looking at it on mapillary.com/map, I see several other sequences
Most of the other sequences are by myself, and are missing from iD for the I 5 between Canada and Seattle.
From mapillary/mapillary_issues#1264
The text was updated successfully, but these errors were encountered: