Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "terms" to "shop/bicycle" to lower user misuse of "bicycle_repair_station" #2845

Closed
brycenesbitt opened this issue Nov 26, 2015 · 4 comments

Comments

@brycenesbitt
Copy link
Contributor

The tag "amenity=bicycle_repair_station" is for unattended tool stands, not shops.
To reduce the number of mistakes, would you considering adding preset shop/bicycle.js:

"shop/bicycle": {
    ...
    "terms": {
        "bicycle repair, bike repair"
    },

So that a search for "repair" brings up both bike shop (a store that sells and repairs bikes), and bicycle_repair_station (a DIY tool stand with no shop).

Right now people are finding bicycle_repair_station first and using it.

@matkoniecz
Copy link
Contributor

Note that there are bicycle shops not offering repair and places where section selling bicycles and repairing them are separated.

@brycenesbitt
Copy link
Contributor Author

Matkoniecz,this tagging works for those cases:

shop=bicycle
service:bicycle:retail=yes
service:bicycle:repair=no

"amenity=bicycle_repair_station" is a do it yourself tool stand, and has nothing to do with a shop.

@brycenesbitt brycenesbitt changed the title Add "terms" to "shop/bicycle" to lower user mistakes Add "terms" to "shop/bicycle" to lower user misuse of "bicycle_repair_station" Nov 26, 2015
@bhousel
Copy link
Member

bhousel commented Dec 8, 2015

"amenity=bicycle_repair_station" is a do it yourself tool stand, and has nothing to do with a shop.

Why not just make the tag amenity=diy_tool_stand?

@brycenesbitt
Copy link
Contributor Author

I will push for that, though some including Andy Allen, have objected.
Adding the terms to iD makes sense regardless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants