Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow user to Continue from connecting way of a closed loop #3749

Closed
bhousel opened this issue Jan 12, 2017 · 1 comment
Closed

Don't allow user to Continue from connecting way of a closed loop #3749

bhousel opened this issue Jan 12, 2017 · 1 comment
Assignees
Labels
operation An editing operation / edit menu item

Comments

@bhousel
Copy link
Member

bhousel commented Jan 12, 2017

There are a bunch of changes forthcoming in #3676 which should prevent duplicate nodes along ways from happening.

A consequence of that is now way.addNode will try to preserve circularity (keep closed ways closed), so continuing a way from the connecting node of a closed loop way could cause the continued segment to loop back over itself.

And anyway it's confusing why one vertex allows it and none others along the way do.

If a user really wants to extend the way from this point, they can just draw another way and connect them there.

@bhousel bhousel added the operation An editing operation / edit menu item label Jan 12, 2017
@bhousel bhousel self-assigned this Jan 12, 2017
@bhousel bhousel added the wip Work in progress label Jan 12, 2017
@bhousel
Copy link
Member Author

bhousel commented Jan 17, 2017

This was done in cb35873

@bhousel bhousel closed this as completed Jan 17, 2017
@bhousel bhousel removed the wip Work in progress label Feb 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
operation An editing operation / edit menu item
Projects
None yet
Development

No branches or pull requests

1 participant