Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order to-be-created relations by dependencies in the changeset #3871

Merged

Conversation

mstn
Copy link
Contributor

@mstn mstn commented Mar 2, 2017

This patch fixes #3208. In details:

  • New relations are ordered in the changeset so that children appear in the file before their parents.
  • Circular dependencies are not ordered because it is not possible. In this case, an osmChange will be generated, but the API will return an error. Ideally, the user interface should prevent users from creating circular dependencies. Hence, this case should not happen.
  • The bug is specific to creations. I do not think that we need a similar fix also for modifications and deletions.

Hope everything ok. Otherwise please let me know! :)

@bhousel
Copy link
Member

bhousel commented Mar 4, 2017

Thanks @mstn! This looks really good 👍
I will try it out over the weekend...

@bhousel
Copy link
Member

bhousel commented Mar 11, 2017

I tested this out and it does reorder the relations.. Thanks again!

@bhousel bhousel merged commit e0157f4 into openstreetmap:master Mar 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't create a new master relation for new relations
2 participants