Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't autofill changeset comment from previous edit, if previous edit was older than some time limit #3947

Closed
boothym opened this issue Apr 4, 2017 · 4 comments
Labels
core An issue with one of the core iD components

Comments

@boothym
Copy link
Contributor

boothym commented Apr 4, 2017

I've seen some new users who keep using the same changeset comment as their first edit. Not a huge problem but a bit annoying, and sometimes new users from Missing Maps/HOT projects edit in their "home" area yet upload with the same comment full of hashtags.

Is this the intended behaviour in iD, to have the previous comment sitting in the box when saving? Tested it myself and the same thing happens when I save, in both Firefox and Chrome.

@bhousel
Copy link
Member

bhousel commented Apr 5, 2017

Yes that's intended. I don't personally have a preference, but some people like that behavior, especially people who make a lot of very similar edits and want to just change a few words in the comment, or people who save frequently.

@bhousel bhousel closed this as completed Apr 5, 2017
@althio
Copy link
Contributor

althio commented Apr 5, 2017

@bhousel

some people like that behavior, especially people who make a lot of very similar edits and want to just change a few words in the comment, or people who save frequently.

That is understandable, but what about a time limit? The changeset comment could get an expiry time so that a new mapping session comes with an empty field.

@boothym
Copy link
Contributor Author

boothym commented Apr 6, 2017

but some people like that behavior, especially people who make a lot of very similar edits and want to just change a few words in the comment, or people who save frequently.

Can't there be a middle ground though, between allowing that behaviour and encouraging newbies to add a proper changeset comment on each upload? With autocomplete in the comment box, along with copy & paste, it shouldn't affect those people you are talking about too badly.

@bhousel
Copy link
Member

bhousel commented Apr 6, 2017

I agree having the automatic comment expire after some time is a good idea...

@bhousel bhousel reopened this Apr 6, 2017
@bhousel bhousel added the core An issue with one of the core iD components label Apr 7, 2017
@bhousel bhousel changed the title Previous changeset comment remains in save box Don't autofill changeset comment from previous edit, if previous edit was older than some time limit Apr 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core An issue with one of the core iD components
Projects
None yet
Development

No branches or pull requests

3 participants