Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wikidata tag is not really added #3987

Closed
rmikke opened this issue Apr 27, 2017 · 2 comments
Closed

wikidata tag is not really added #3987

rmikke opened this issue Apr 27, 2017 · 2 comments
Labels
bug A bug - let's fix this!

Comments

@rmikke
Copy link

rmikke commented Apr 27, 2017

Automatic adding of wikidata does not work correctly.

Here are steps to reproduce the error:

  1. Open an object for edition. I usually do it from OSMOSE or Overpass.
  2. Add or change wikipedia field. You can see that wikidata is added automatically. So far so good.
  3. Save the object (i.e. commit the changeset), close the tab in browser.
  4. Reenter the same object. The wikidata tag is gone in most cases.

Sometimes I could even actually see wikidata tag vanishing from list of all tags the moment I clicked Save, before the list is replaced by the place for a changeset comment.

I can't see any regularity when the wikidata tag is saved and when it is discarded.

@tyrasd tyrasd added the bug A bug - let's fix this! label Apr 27, 2017
@tyrasd
Copy link
Member

tyrasd commented Apr 27, 2017

Confirming. As far as I can tell, this happens all the time when one saves when the cursor is still in the wikipedia field (i.e. one hasn't clicked/tabbed out of the input field or hasn't deselected the respective object).

@rmikke
Copy link
Author

rmikke commented Apr 28, 2017

Yup, that's it. When I move focus out of the Wikipedia field, wikidata tag stays. What's more, when clicking out to the Wikipedia field, I can see wikidata tag being removed and reinserted again. I.e.it's inserted when I choose the value for wikipedia field, then removed and reinserted when I click or tab out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug - let's fix this!
Projects
None yet
Development

No branches or pull requests

3 participants