Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make background imagery names translatable #4034

Closed
manfredbrandl opened this issue May 10, 2017 · 7 comments
Closed

Make background imagery names translatable #4034

manfredbrandl opened this issue May 10, 2017 · 7 comments
Labels
localization Adapting iD across languages, regions, and cultures

Comments

@manfredbrandl
Copy link
Contributor

Are these items from iD or do i have to translate somewhere else?
image

@bhousel
Copy link
Member

bhousel commented May 10, 2017

Oh we actually have an issue for this in editor-layer-index: osmlab/editor-layer-index#17

I'm not sure the best way to do it. I could see it either being localized in that project, or in iD. Maybe I should just add it as another resource to the id-editor team on transifex for the imagery list. Then we wouldn't need to ask people to sign up for another project.

@bhousel bhousel added localization Adapting iD across languages, regions, and cultures waitfor-upstream Waiting for something in an upstream project labels May 10, 2017
@althio
Copy link
Contributor

althio commented May 10, 2017

@bhousel
I think @manfredbrandl refered to "Locator Overlay" & "OpenStreetMap GPS traces" while I think you responded on the imagery list instead.

@bhousel
Copy link
Member

bhousel commented May 10, 2017

I think @manfredbrandl refered to "Locator Overlay" & "OpenStreetMap GPS traces" while I think you responded on the imagery list instead.

Yes, but they all come from the imagery list, the overlay sources just have checkboxes instead of radio buttons.

@bhousel bhousel changed the title Make items translatable Make background imagery names translatable Jun 4, 2017
@manfredbrandl
Copy link
Contributor Author

There is a PR in editor-layer-index to solve that problem osmlab/editor-layer-index#343

@bhousel
Copy link
Member

bhousel commented Jun 15, 2017

The upstream work was done and we now have a new imagery resource attached to the iD project. Next steps are for me to merge this resource into iD's language files and use t() in the Background pane to display the texts.

@bhousel bhousel removed the waitfor-upstream Waiting for something in an upstream project label Jun 15, 2017
@manfredbrandl
Copy link
Contributor Author

I can translate the layer names in transifex-ideditor-imagery and see the effect on preview.ideditor.com/master Thanks!

@bhousel
Copy link
Member

bhousel commented Jun 16, 2017

Great, I just also added support to display translated attribution text too, so closing here 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
localization Adapting iD across languages, regions, and cultures
Projects
None yet
Development

No branches or pull requests

3 participants