Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging gas station and roof removes the roof tag #4114

Closed
bhousel opened this issue Jun 22, 2017 · 1 comment
Closed

Merging gas station and roof removes the roof tag #4114

bhousel opened this issue Jun 22, 2017 · 1 comment
Labels
bug A bug - let's fix this!

Comments

@bhousel
Copy link
Member

bhousel commented Jun 22, 2017

As reported on OSM-US Slack:
https://osmus.slack.com/archives/C029HV951/p1498113350658018

Using iD 2.2.2, I'm merging a node with tags amenity=fuel and name=Costco Gas, with a closed way with building=roof. I expected the resulting closed way to have all three tags, but it dropped building=roof. Is this expected? I think iD's behavior earlier was to merge all three tags.

This is related to #4113, in that it's the same kind of merge. The building=roof tag shouldn't be discarded after merging.

merge roof

@bhousel bhousel added the bug A bug - let's fix this! label Jun 22, 2017
@bhousel
Copy link
Member Author

bhousel commented Jun 22, 2017

Fix for this was a little weird, but the point-merge operation handles tags a little better now.

After #3851 we are now rematching the preset after a merge.
With this fix we now:

  • don't remove the old preset's tags (which was over-aggressively removing the building=roof),
  • do remove any existing area=yes when adding the tags for the new preset,
    (just before the code that decides whether an area=yes tag is really necessary).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug - let's fix this!
Projects
None yet
Development

No branches or pull requests

1 participant