Vector Tiles pt 2 #5243
Merged
Vector Tiles pt 2 #5243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems like the ids stored in the features are not reliable, so I'm trying to generate ids
If we return the original feature, and then change the hash later as the feature merges with another, d3 won't exit/enter because it is joining on the new hash, not the originally hash.
|
This is ready to merge! I've added the ability to hover over data and select it. Internally the data is stored as GeoJSON, so we show whatever is in I'm still considering this feature somewhat "beta", but I'll release a new version of iD in the next day or so that allows users to play around with it, and will include a few example vector tile layers which can help mappers participating in the Detroit Mapping Challenge.
|
This was referenced Aug 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still a bit of cleanup to do, but this PR merges:
These features now live on a single layer called "Custom Map Data" (yes we will support multiple custom layers soon) and it has a settings screen (like #5207 screen added for custom background imagery). Users can choose a local file, enter a url to a remote file or a url template for a vector tile source:
It currently converts the vector tile data to geojson on the fly and renders just like the old gpx layer did (better styling coming soon too)!
HUGE thanks to @vershwal for her Google Summer of Code work that made this possible and @geohacker for being an awesome mentor 🙌