Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some support for non-yes/no multicombo fields #5291

Closed
bhousel opened this issue Sep 4, 2018 · 0 comments
Closed

Some support for non-yes/no multicombo fields #5291

bhousel opened this issue Sep 4, 2018 · 0 comments
Labels
field An issue with a field in the user interface

Comments

@bhousel
Copy link
Member

bhousel commented Sep 4, 2018

Most of the multiCombo fields supported by iD are 'yes'/'no' only.

recycling:whatever = yes/no wiki
fuel:whatever = yes/no wiki
monitoring:whatever = yes/no wiki

But for some of them, people have decided that they want to put other values in there:
payment:whatever = yes/no/interval wiki

The new language field needed for #5261 works like this too:
language:whatever = yes/no/main wiki

Previously I was lazy and just ignored all the non-'yes' values. Going forward, iD will treat anything non-'no' as if the value is set, and make sure not to overwrite it's special value with a 'yes' if the user tries to re-add it again in the multiselect field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
field An issue with a field in the user interface
Projects
None yet
Development

No branches or pull requests

1 participant