Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the member geometry type to the label of non-downloaded relation members #5399

Conversation

quincylvania
Copy link
Collaborator

With #5396 merged, users can now manually download individual members. The issue is that that it is difficult to tell what the member is before it is downloaded. While the member's role is shown in the input field and its index is indicated by its list order, its geometry type is available but hidden. This PR adds the type (node, way, or relation) to the non-downloaded member's label. This should make it slightly easier for users to determine what members to try downloading, as well as surface potential mistakes such as node members with north or south roles.

A potential drawback is that novice users may be confused by the node/way terminology since iD hides it behind points, lines, and areas, but I don't think that novice users will be editing complex relations anyway.

screen shot 2018-10-11 at 7 36 21 pm

@quincylvania quincylvania self-assigned this Oct 12, 2018
@bhousel
Copy link
Member

bhousel commented Oct 12, 2018

A potential drawback is that novice users may be confused by the node/way terminology since iD hides it behind points, lines, and areas, but I don't think that novice users will be editing complex relations anyway.

I'm ok with this - we use the Node/Way terminology in a few other places that are more intended for advanced users.

@bhousel bhousel merged commit ef3d251 into openstreetmap:master Oct 12, 2018
@quincylvania quincylvania deleted the osm-type-label-incomplete-relation-member branch October 12, 2018 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants