Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open help menu by pressing Persian equivalent of question mark #5675

Closed
iriman opened this issue Jan 4, 2019 · 6 comments
Closed

Open help menu by pressing Persian equivalent of question mark #5675

iriman opened this issue Jan 4, 2019 · 6 comments
Labels
localization Adapting iD across languages, regions, and cultures

Comments

@iriman
Copy link
Contributor

iriman commented Jan 4, 2019

In Persian keyboard layouts we have this char ؟ for question mark.
It is in the same place as the key ? and we write it by holding down the Shift key, just like English.
But when I type ؟, it toggles minimap.
It would be so good if we can use both of them to open the help pane.

@manfredbrandl
Copy link
Contributor

You can „translate“ the shortcut key on Transifex
https://github.com/openstreetmap/iD/blob/master/CONTRIBUTING.md#translating
You can test the latest translations: http://preview.ideditor.com/master

@1ec5
Copy link
Collaborator

1ec5 commented Jan 4, 2019

Specifically, the keys to translate are help.key and minimap.key.

@bhousel bhousel added localization Adapting iD across languages, regions, and cultures waitfor Waiting for something labels Jan 6, 2019
@bhousel
Copy link
Member

bhousel commented Jan 6, 2019

@iriman - try out the suggestion by @manfredbrandl and @1ec5 and let us know if that works.

@iriman
Copy link
Contributor Author

iriman commented Jan 6, 2019

Oh, sorry guys. I lost access to my PC for some days. I will check it as soon as possible.
Thank you for your really quick & kind guide.

@iriman
Copy link
Contributor Author

iriman commented Jan 6, 2019

Finally I get back to my PC :)
I translated shortcuts.toggle.key to ؟, but now if I press ? it has no reaction.
It's best to have both ? and ؟ shortcuts enabled, since mostly every one with a Persian keyboard layout has an English one, too. So every time we should check if it's Persian or not to have a working shortcut key.

To explain more precisely, now we have H for help.key.
Its translation is the same as source string: H.
On my Persian keyboard, the character alef (ا) is at the position of key h.
If I press h or ا (alef) on my keyboard, help pane will be opened.

@bhousel
Copy link
Member

bhousel commented Jan 6, 2019

ah ok, this will need something like I did for #5663 then.

@bhousel bhousel removed the waitfor Waiting for something label Jan 6, 2019
@bhousel bhousel closed this as completed in 4ed2858 Jan 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
localization Adapting iD across languages, regions, and cultures
Projects
None yet
Development

No branches or pull requests

4 participants