Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Osmose Q/A layer #5682

Closed
bhousel opened this issue Jan 7, 2019 · 2 comments · Fixed by #7095
Closed

Add Osmose Q/A layer #5682

bhousel opened this issue Jan 7, 2019 · 2 comments · Fixed by #7095
Assignees
Labels
validation An issue with the validation or Q/A code
Milestone

Comments

@bhousel
Copy link
Member

bhousel commented Jan 7, 2019

Following #5201 - we can add a Q/A layer for Osmose

Some information about the ruleset and API can be found on the osm wiki.

The list of checks that Osmose performs is here - we'll want to support a reasonable subset of these.

Similar to KeepRight, we can just pick a single marker style and a few colors to differentiate, rather than trying to match the literal osmose icons, which don't seem to mean anything.

screenshot 2019-01-07 12 28 39

@bhousel bhousel added the validation An issue with the validation or Q/A code label Jan 7, 2019
@kymckay
Copy link
Collaborator

kymckay commented Jan 7, 2019

Osmose API is quite nice as it directly provides array of element IDs related to the error unlike KeepRight. See "elems" key.

Full error detail is not provided (by default) when fetching errors from /errors unless full=true parameter is specified in the query. Unsure whether implementation would want to fetch specific error detail separately when an error is interacted via /error/ID as a means to reduce the amount of data transfer or if that's not a big deal.

Just some food for though, I've messed around with my own half-baked implementation of this in the past, but I'm mostly commenting so this appears in my participating notifications 😛

@tordans
Copy link
Collaborator

tordans commented Feb 15, 2020

For all wo are looking to test this feature, ATM its live at https://2-x--ideditor.netlify.com/#background=Bing&disable_features=boundaries&map=16.94/52.47562/13.44827

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
validation An issue with the validation or Q/A code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants