Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more links to the link bar of the inspector #5706

Closed
slhh opened this issue Jan 14, 2019 · 4 comments
Closed

Add more links to the link bar of the inspector #5706

slhh opened this issue Jan 14, 2019 · 4 comments
Labels
wontfix Not planning to work on this at this time

Comments

@slhh
Copy link
Contributor

slhh commented Jan 14, 2019

iD has recently got a linkbar in the inspector (#5169 (comment)).
In addition to the zoom, the following links or icons could be useful there:

  1. Upgrade tags (Should iD just offer to upgrade tags? #4591 (comment))
  2. Download an incompletely downloaded relation (Add button for complete member download. #5420). The shown link could also serve as an indicator of incompleteness.
  3. Go back to:
    1. the parent relation, when the currectly selected element was selected by clicking an item in the all members section of the parent relation.
    2. the member, when the currect element (a relation) was selected by clicking an item in the all memberships section of the member.
  4. Go forward (undo go back)
  5. Restore the recent multiselection, when the currect element was selected by clicking an item in the multiseletion list.or any subsequent browsing through all members or all memberships item links.
  6. Add the current element to the stored previous multiselection.
  7. Add the current element to the stored previous multiselection.

To prevent cluttering the UI, links should be hidden, when they are inapplicable. Most links are applicable in relatively rare cases only. They would be shown just when they are likely required.
Typical workflows of a Newbie would unlikely led to activation of links 3. to 7., and activated links would get hidden again quite soon.

@bhousel
Copy link
Member

bhousel commented Jan 14, 2019

I don't want to add a lot of stuff to the top link bar. I still want to keep the sidebar mostly like

Simple / easy to use / universally understandable
↓↓↓
Complex / requires knowledge / fiddly osm details

I'm ok with adding link bars to the other sections though.. e.g. download all relations can go down near the relation parts.

@bhousel bhousel added the considering Not Actionable - still considering if this is something we want label Jan 14, 2019
@slhh
Copy link
Contributor Author

slhh commented Jan 15, 2019

download all relations can go down near the relation parts.

We need to differentiate two different types of usecases for downloading of relation members.

  1. When user intends to work with the member list., placing the download link in the all members section seem to be perfect. Downloading direct members of the relation might be sufficient in this case.
  2. The usecase which I had in mind is the following: The user intends to use an edit memu operation, e.g. a geometrical one like a multipolygon area split. We need a full download including nodes to allow geometrical computations. A multipolygon is just a special area, and it is displayed in iD like an area.
    A user intending to modify the geometry should not need to go down to all members to download. Instead, the user should be able just to download missing data without any need to care about being a relation.

Maybe we can avoid single operand operations which need a complete download of the selected relation. In this case a download link to support usecase 2 could be placed in the multi-selection view. How about placing a link bar below the list of selected items there? It might be useful for other things too.

@bhousel
Copy link
Member

bhousel commented Jan 15, 2019

We need to differentiate two different types of usecases for downloading of relation members.

If #5180 were implemented (a background worker queue), we could probably just fully download and parse reasonable relations using a web worker and the user would not even need to be bothered by this.

@quincylvania
Copy link
Collaborator

For iD v3 I converted the "Zoom to this" link to a toolbar item. Most of the items in @slhh's original list could possibly be toolbar items as well. In any case, I don't really see us adding these links as described.

@quincylvania quincylvania added wontfix Not planning to work on this at this time and removed considering Not Actionable - still considering if this is something we want labels Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix Not planning to work on this at this time
Projects
None yet
Development

No branches or pull requests

3 participants