Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure name-suggestion presets are inheriting the correct fields #5713

Closed
bhousel opened this issue Jan 15, 2019 · 0 comments
Closed

Make sure name-suggestion presets are inheriting the correct fields #5713

bhousel opened this issue Jan 15, 2019 · 0 comments
Labels
field An issue with a field in the user interface preset An issue with an OpenStreetMap preset or tag

Comments

@bhousel
Copy link
Member

bhousel commented Jan 15, 2019

This relates to #5710

Here is a Marathon fuel station with brand:wikidata=Q458363.. This made it match the Marathon gas station preset, which is great! But it should also show a building field with the value "roof", which is missing. I have to look into why.

I think the brand presets field lists are currently just copied from the original presets, and they should instead inherit the fields of them (once #5710 is done).

screenshot 2019-01-15 13 01 36

@bhousel bhousel added field An issue with a field in the user interface wip Work in progress preset An issue with an OpenStreetMap preset or tag labels Jan 15, 2019
@bhousel bhousel removed the wip Work in progress label Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
field An issue with a field in the user interface preset An issue with an OpenStreetMap preset or tag
Projects
None yet
Development

No branches or pull requests

1 participant