Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some of background imagery names and descriptions translation do not overwrite #5737

Closed
higa4 opened this issue Jan 19, 2019 · 5 comments
Closed

Comments

@higa4
Copy link

higa4 commented Jan 19, 2019

There are four background layer on editor-layer-index project's geojson in asia/jp.
https://github.com/osmlab/editor-layer-index/tree/gh-pages/sources/asia/jp
I set "i18n": true for these and traslated all of these names and descriptions on transifex which are expected to be shown on the "Background" panel of iD.
But only 1/4 is correctly overwritten by translated text and other 3/4 are not. (red square below)

correctly overwritten:

not overwritten:

@bhousel
Copy link
Member

bhousel commented Jan 19, 2019

These look like the translations are all available on http://preview.ideditor.com/master - is this right?

The dev mirror is updated frequently, whereas the iD on openstreetmap.org is only updated when we make a new release of iD.

@bhousel bhousel added the waitfor-info Waiting for more info label Jan 19, 2019
@higa4
Copy link
Author

higa4 commented Jan 19, 2019

These look like the translations are all available on http://preview.ideditor.com/master - is this right?

Yes, translations are already done on transifex and I'm checking on http://preview.ideditor.com/master .
3) was merged just yesterday, but 1) 2) and 4) was merged last August (about 5 months ago).

@bhousel bhousel removed the waitfor-info Waiting for more info label Jan 19, 2019
@bhousel
Copy link
Member

bhousel commented Jan 19, 2019

Ah ok, I just checked. I think this is probably because the imagery identifiers have . characters in them. iD uses this character to delimit the translation keys.

There is a workaround in the code (search for TX_DOT) that replaces a single . and I need to change it to replace all the .s

@bhousel
Copy link
Member

bhousel commented Jan 19, 2019

Thanks for reporting @higa4 - I just pushed a fix.. Can you check this again in preview later today?

@higa4
Copy link
Author

higa4 commented Jan 19, 2019

I just checked and it looks fine. Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants