Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Presets for LGBTQ+ venues #5940

Merged
merged 2 commits into from
Feb 27, 2019
Merged

Presets for LGBTQ+ venues #5940

merged 2 commits into from
Feb 27, 2019

Conversation

amandasaurus
Copy link
Contributor

Here I add a few presets for LGBTQ+ venues, based on the lgbtq tagging scheme.

@quincylvania
Copy link
Collaborator

Hi @rory! Thanks for opening this—could you change just a few little organization details?

  • Instead of paths like amenity/lgbtq_bar.json can you change them to be like amenity/bar/lgbtq.json?
  • Once you do that, you can delete the fields and moreFields properties. They will inherit the same fields as the base preset.

Then we can merge ➡️🆔

@quincylvania quincylvania added the preset An issue with an OpenStreetMap preset or tag label Feb 25, 2019
@amandasaurus
Copy link
Contributor Author

I didn't know you could do that with presets. I have made those changes and updated the branch.

@quincylvania quincylvania merged commit ff49a0c into openstreetmap:master Feb 27, 2019
@quincylvania
Copy link
Collaborator

Looks great, thanks @rory 👍

I didn't know you could do that with presets.

We added field inheritance relatively recently (2.13.0?). It's been great for keeping similar presets consistent and avoiding duplicate data.

@quincylvania quincylvania added this to the Next Release milestone Feb 27, 2019
@bhousel bhousel mentioned this pull request May 21, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
preset An issue with an OpenStreetMap preset or tag
Projects
None yet
Milestone
2.15.0
Development

Successfully merging this pull request may close these issues.
2 participants
@amandasaurus @quincylvania