Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS "nowrap" for help dialogue #6174

Closed
tordans opened this issue Apr 12, 2019 · 3 comments
Closed

CSS "nowrap" for help dialogue #6174

tordans opened this issue Apr 12, 2019 · 3 comments
Assignees
Labels
usability An issue with ease-of-use or design
Milestone

Comments

@tordans
Copy link
Collaborator

tordans commented Apr 12, 2019

When you view the help dialogue in German, the keyboard shortcuts have linebreaks. This makes the view less nice a harder to read and understand.

Testcase: https://www.openstreetmap.org/edit?locale=de

Possible fix: Add white-space: nowrap; to the .modal-shortcuts .shortcut-keys.

See screenshot before / after.

with line breaks

without line breaks and css fix

@manfredbrandl
Copy link
Contributor

@tordans I shortend the explanations: "Festhalten verhindert Vereinigen beim Platzieren", "Trenne den Knoten von seinen Linien/Flächen", "Ecken eines Weges/einer Fläche rechtwinklig machen". Looks good:
image

@bhousel
Copy link
Member

bhousel commented Apr 12, 2019

Thanks @manfredbrandl that looks much better 👍
I do agree with @tordans that we should nowrap the shortcut keys.

@bhousel bhousel added the usability An issue with ease-of-use or design label Apr 12, 2019
@quincylvania quincylvania self-assigned this Apr 12, 2019
@quincylvania
Copy link
Collaborator

Done in 0c29054. I also made this UI responsive so the two columns wrap to one on smaller displays.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
usability An issue with ease-of-use or design
Projects
None yet
Development

No branches or pull requests

4 participants