Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amenity=preschool validator warning should also add preschool=yes #6636

Closed
1ec5 opened this issue Jul 8, 2019 · 7 comments
Closed

amenity=preschool validator warning should also add preschool=yes #6636

1ec5 opened this issue Jul 8, 2019 · 7 comments
Assignees
Labels
validation An issue with the validation or Q/A code
Milestone

Comments

@1ec5
Copy link
Collaborator

1ec5 commented Jul 8, 2019

The validator warning about the deprecated amenity=preschool tag should suggest adding preschool=yes in addition to setting amenity=kindergarten. Otherwise, the suggested fix would potentially lose information.

@1ec5 1ec5 added the validation An issue with the validation or Q/A code label Jul 8, 2019
@quincylvania quincylvania self-assigned this Jul 9, 2019
@quincylvania quincylvania added this to the 2.15.4 milestone Jul 9, 2019
@quincylvania
Copy link
Collaborator

quincylvania commented Jul 9, 2019

Did this. Also added a checkmark field for preschool.

@DaveF63
Copy link

DaveF63 commented Aug 6, 2019

Kindergarten is a preschool. This tag duplicates data.

@tas50
Copy link

tas50 commented Aug 6, 2019

@DaveF63 see https://wiki.openstreetmap.org/wiki/Tag:amenity%3Dpreschool

The suggestion on the wiki seems super wrong to me as here on the west coast of the US a pre-school and a kindergarden are VERY different things.

@DaveF63
Copy link

DaveF63 commented Aug 6, 2019

@quincylvania
Copy link
Collaborator

Kindergarten is a preschool. This tag duplicates data.

The suggestion on the wiki seems super wrong to me as here on the west coast of the US a pre-school and a kindergarden are VERY different things.

In the US these are similar but are generally considered different things. This tagging scheme isn't perfect but at least it accommodates both situations. In places where there's a difference, the preschool tag differentiates them. In other places the tag can be ignored.

@DaveF63
Copy link

DaveF63 commented Aug 6, 2019

@quincylvania

  1. OSM doesn't tag to suit interpretations on one side of the pond.
  2. Duplication in OSM is to be avoided at all costs. it just leads to errors. I thought you'd have learnt about that after the platform/footway mess.

@quincylvania
Copy link
Collaborator

@DaveF63 iD is following the advice of the wiki here. Feel free to disagree. I don't care to argue further and I don't have time to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
validation An issue with the validation or Q/A code
Projects
None yet
Development

No branches or pull requests

4 participants