Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download all parent relations when a child is selected in low zoom editing. #6731

Closed
BjornRasmussen opened this issue Aug 7, 2019 · 4 comments
Assignees
Labels
bug A bug - let's fix this!
Milestone

Comments

@BjornRasmussen
Copy link
Contributor

When editing at super high zooms, I found myself selecting objects that had been downloaded but weren't in the downloaded area in order to look at the parent relations (huge multipolygons) of those objects. Unfortunately, since they weren't downloaded already, the relations section of those objects said "Relations (0)".

I think that when an object is selected in low zoom editing, all parent relations should be downloaded so that they can be shown in the "Relations" section of that object. Obviously, the members of those relations should not be downloaded, since doing so would destroy performance on most machines.

@BjornRasmussen
Copy link
Contributor Author

Also, note that the current code doesn't update the relations section when new relations are downloaded. This should be fixed, such that the finishing of downloading an area (or tile?) triggers the redraw of the relations section of the selected object.

@quincylvania quincylvania added the bug A bug - let's fix this! label Dec 18, 2019
@quincylvania
Copy link
Collaborator

I'm going to consider this a bug since a feature's relations should always be available when it's selected. Note that I moved the low-zoom inspection behavior to 2.17.0 but not the functionality where the id URL parameter will override the map parameter, which could cause this bug most easily.

@slhh
Copy link
Contributor

slhh commented Dec 19, 2019

I would expect the following sequence to potentially cause the issue:

  1. The user selects a large relation
  2. Missing members are automatically downloaded, but without their parent relations.
  3. In extra low zoom, the user selects one of these members (on the map or in all members).

iD does likely need to do some bookkeeping whether the parent relations of an element have been downloaded (element has been returnend from a map API call or parent relations have been explicitly requested), and download missing parent relations of the selected element when entering mode select.

@quincylvania
Copy link
Collaborator

Looks like there's an endpoint for this that iD isn't using yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug - let's fix this!
Projects
None yet
Development

No branches or pull requests

3 participants