Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow limiting fields to specific countries/regions #7085

Closed
quincylvania opened this issue Dec 3, 2019 · 2 comments
Closed

Allow limiting fields to specific countries/regions #7085

quincylvania opened this issue Dec 3, 2019 · 2 comments
Assignees
Labels
preset An issue with an OpenStreetMap preset or tag
Milestone

Comments

@quincylvania
Copy link
Collaborator

There's the potential for certain advanced fields that only apply to particular countries such as a business's VAT number (see #6880 (comment)) or GNIS ID. Now that we've done #6941, looking up country codes is relatively free. Like presets, we could have countryCodes and notCountryCodes properties for fields.

@quincylvania quincylvania added the preset An issue with an OpenStreetMap preset or tag label Dec 3, 2019
@quincylvania quincylvania self-assigned this Dec 3, 2019
@quincylvania quincylvania added this to the 2.16.1 milestone Dec 4, 2019
@bhousel
Copy link
Member

bhousel commented Dec 4, 2019

Oh hey! You beat me to this..
I'm working on a general way of representing these for other projects too (name-suggestion-index, osm-community-index, whatever we decide to do with editor-layer-index), and I'll have this working in the location-conflation project in the next few days.

👉 Would you consider a schema like:

locations: {
  include: [Array],
  exclude: [Array]
}

The arrays may contain anything that country-coder recognizes, but I'm also supporting other stuff too (like a example.geojson filename). This gives us the flexibility to support non-country-coded things like "Scotland" or "French-speaking Canada", which we need for some communities in OCI, or some brand extents in NSI.

@quincylvania
Copy link
Collaborator Author

@bhousel Sure, it'd be great to have more flexibility and take advantage of that project 👍

We can also switch the preset properties, though that will be a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preset An issue with an OpenStreetMap preset or tag
Projects
None yet
Development

No branches or pull requests

2 participants