Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add field for ruins=* #7507

Merged
merged 1 commit into from
May 5, 2020
Merged

Add field for ruins=* #7507

merged 1 commit into from
May 5, 2020

Conversation

hikemaniac
Copy link
Contributor

This PR adds a field for ruins=* to the Ruins preset.

@hikemaniac hikemaniac closed this Apr 11, 2020
@hikemaniac hikemaniac reopened this Apr 11, 2020
@quincylvania
Copy link
Collaborator

@hikemaniac Hmm are you sure the ruins key should be used this way? Mostly it looks like people are just adding ruins=yes to historic things and buildings.

@quincylvania quincylvania added considering Not Actionable - still considering if this is something we want preset An issue with an OpenStreetMap preset or tag labels Apr 12, 2020
@hikemaniac
Copy link
Contributor Author

@quincylvania Sorry for the late reply. I see your point and even though the wiki mentions that

In some cases the value of the "ruins" tag has been used to provide additional information

it is only used 4088 times (5.1 % of total use) with values other than "yes" or "no". The wiki page for historic=ruins suggests ruins=* as a useful combination to add more information and claims that

Although they both provide similar information, a form such as historic=ruins, ruins=castle suggests a structure that is mainly in ruins, while a form such as historic=castle, ruins=yes suggests a structure that still appears much like a castle.

so it seems to make a semantic difference. While I believe it makes sense to add this to the Ruins preset, the choice between a different historic=* preset or Ruins might be made more confusing by the addition of the ruins=* field. What is your opinion on this?

@quincylvania quincylvania merged commit f7a4dc5 into openstreetmap:develop May 5, 2020
@quincylvania quincylvania removed the considering Not Actionable - still considering if this is something we want label May 5, 2020
@quincylvania quincylvania added this to the Next Release milestone May 5, 2020
@quincylvania
Copy link
Collaborator

Thinking more about this, it does seem safer and more correct to say "these are ruins, this was a church" than to say "this is a church, it is in ruins". It's not a church anymore. Though supporting one pattern doesn't mean mappers can't use the other.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preset An issue with an OpenStreetMap preset or tag
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants