Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

renamed metal construction preset #7568

Merged
merged 2 commits into from
May 10, 2020
Merged

renamed metal construction preset #7568

merged 2 commits into from
May 10, 2020

Conversation

animesh-007
Copy link
Contributor

Renamed Metal Construction preset to Metal Working #7549
Screen Shot 2020-05-05 at 4 48 23 PM

1ec5
1ec5 reviewed May 5, 2020
View reviewed changes
Copy link
Collaborator

@1ec5 1ec5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this change! There are a few things left to clean up so that the raw tag remains craft=metal_construction. Once you make these changes, remember to rebuild iD (npm install && npm run all) to update the remaining files.

data/presets/presets/craft/metal_working.json Outdated Show resolved Hide resolved
data/presets.yaml Outdated Show resolved Hide resolved
data/presets/presets.json Outdated Show resolved Hide resolved
@animesh-007
Copy link
Contributor Author

@1ec5 Thanks for suggestions. I have made those changes.

1ec5
1ec5 approved these changes May 6, 2020
View reviewed changes
dist/locales/en.json Outdated Show resolved Hide resolved
@quincylvania
Copy link
Collaborator

What do you all think about the name "Metalworker" instead? Lots of the craft presets are like "Plumber", "Roofer", "Painter", "Photographer"…

@1ec5
Copy link
Collaborator

1ec5 commented May 7, 2020

That seems reasonable to me.

@quincylvania quincylvania merged commit 9b2263f into openstreetmap:develop May 10, 2020
@quincylvania
Copy link
Collaborator

@animesh-007 @1ec5 Thanks!!

@quincylvania quincylvania mentioned this pull request May 10, 2020
Closed
@quincylvania quincylvania added this to the Next Release milestone May 10, 2020
@quincylvania quincylvania added the preset An issue with an OpenStreetMap preset or tag label May 10, 2020
@quincylvania quincylvania modified the milestones: Next Release, 2.18.0 May 18, 2020
@quincylvania quincylvania mentioned this pull request Jul 20, 2020
Merged
@animesh-007 animesh-007 deleted the 7549 branch September 25, 2020 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1ec5 1ec5 1ec5 approved these changes

@quincylvania quincylvania quincylvania left review comments

Assignees
No one assigned
Labels
preset An issue with an OpenStreetMap preset or tag
Projects
None yet
Milestone
2.18.0
Development

Successfully merging this pull request may close these issues.
3 participants
@animesh-007 @quincylvania @1ec5