Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localize the locator overlay to the extent possible #7737

Open
quincylvania opened this issue Jun 25, 2020 · 4 comments
Open

Localize the locator overlay to the extent possible #7737

quincylvania opened this issue Jun 25, 2020 · 4 comments
Labels
localization Adapting iD across languages, regions, and cultures

Comments

@quincylvania
Copy link
Collaborator

The new Mapbox locator overlay is great, but it currently shows labels only in their local language(s). It'd be better to request tiles in the user's language if it's one that's supported by Mapbox. Cc: @mikelmaron

Screen Shot 2020-06-25 at 11 24 17 AM

image

@quincylvania quincylvania added the localization Adapting iD across languages, regions, and cultures label Jun 25, 2020
@mikelmaron
Copy link

@quincylvania there's a couple ways this could be achieved. we could create different styles for each language, and iD would request the appropriate one for the users environment. or iD could use vector rather than raster tiles, and modify the styling on the front end; that is simple to code, but would mean dependency on a library to handle vector tiles.

@quincylvania
Copy link
Collaborator Author

quincylvania commented Jun 25, 2020

@mikelmaron Hmm I'd rather not add a vector tile library just for this. Vector tiles are probably something iD should have first-class support for eventually. You can sort of load an vector tile endpoint as the custom map data layer, but the support is minimal and bug-prone.

For now I think it's fine to swap between language-specific styles. Though I'm assuming it's tough to keep them in sync, so this can wait until everyone's satisfied with the styling.

@mikelmaron
Copy link

Yes makes sense to launch the new style, make sure there's no issues with the styling, and then look at cloning and tweaking for different languages.

In parallel, presume this wouldn't be too hard to implement in iD. However I'm not clear how we'd add this to the ELI in a way that wouldn't explode the number of overlay layers available.

@quincylvania
Copy link
Collaborator Author

A couple remaining issues with the styling, some natural feature labels are either light on light or dark on dark. I think all the labels either need a dark halo with white text or the reverse.

Screen Shot 2021-01-05 at 10 57 15 AM

Screen Shot 2021-01-05 at 10 56 13 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
localization Adapting iD across languages, regions, and cultures
Projects
None yet
Development

No branches or pull requests

2 participants