-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Localize the locator overlay to the extent possible #7737
Comments
@quincylvania there's a couple ways this could be achieved. we could create different styles for each language, and iD would request the appropriate one for the users environment. or iD could use vector rather than raster tiles, and modify the styling on the front end; that is simple to code, but would mean dependency on a library to handle vector tiles. |
@mikelmaron Hmm I'd rather not add a vector tile library just for this. Vector tiles are probably something iD should have first-class support for eventually. You can sort of load an vector tile endpoint as the custom map data layer, but the support is minimal and bug-prone. For now I think it's fine to swap between language-specific styles. Though I'm assuming it's tough to keep them in sync, so this can wait until everyone's satisfied with the styling. |
Yes makes sense to launch the new style, make sure there's no issues with the styling, and then look at cloning and tweaking for different languages. In parallel, presume this wouldn't be too hard to implement in iD. However I'm not clear how we'd add this to the ELI in a way that wouldn't explode the number of overlay layers available. |
The new Mapbox locator overlay is great, but it currently shows labels only in their local language(s). It'd be better to request tiles in the user's language if it's one that's supported by Mapbox. Cc: @mikelmaron
The text was updated successfully, but these errors were encountered: