Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update help and walkthrough for touch interactions #7745

Merged
merged 37 commits into from
Jul 13, 2020

Conversation

quincylvania
Copy link
Collaborator

@quincylvania quincylvania commented Jun 26, 2020

Closes #7692.

Creating a PR for this since the documentation is foundational and the more eyes we can get on it the better. Also, this will invalidate the translations of lots of long strings, so I'd like to get it right the first time.

My strategy for the walkthrough is only showing instructions specific to the last-used input device. I suspect most users will use the same input device throughout the entire walkthrough, but this is adaptive nonetheless.

@quincylvania quincylvania added the walkthrough-help An issue with the walkthrough or help pane label Jun 26, 2020
@quincylvania quincylvania added this to the 2.18.0 milestone Jun 26, 2020
quincylvania and others added 21 commits June 26, 2020 17:18
Use a reusable format for the section title counts
Use keyboard styling for keys referenced in the walkthrough
Add mouse icons for left/right click referenced in the walkthrough
Add labels for all buttons referenced by icon in the walkthrough
Update the lines walkthrough chapter for touchscreens
Add toggled dispatch event to the edit menu
@quincylvania quincylvania marked this pull request as ready for review July 10, 2020 21:07
@quincylvania
Copy link
Collaborator Author

quincylvania commented Jul 10, 2020

So since we have to change a lot of strings anyway for touch support, it's a good opportunity for some other upgrades.

I added a whole lot more placeholders so the labels in the documentation will always match the labels in the UI. The walkthrough strings now use the same placeholder list as the help pane. I also made the inline hotkey styling consistent with tooltips and the shortcuts lists.

I've finished updating the walkthrough. When possible, I tried to use the same strings for both mouse and touch interactions. When interaction instructions are required, iD detects if the mapper is using touch or not. The possibility of an attached keyboard is left open.

The help pane isn't done yet, but I might go ahead and merge anyway so translators can get started.

IMG_0005

@quincylvania quincylvania changed the title Update help and walkthrough for touch interactions Update walkthrough for touch interactions Jul 10, 2020
@quincylvania quincylvania changed the title Update walkthrough for touch interactions Update help and walkthrough for touch interactions Jul 13, 2020
@quincylvania quincylvania merged commit 223137c into develop Jul 13, 2020
@quincylvania quincylvania deleted the touch-walkthrough-update branch July 13, 2020 18:35
@quincylvania quincylvania self-assigned this Jul 13, 2020
@quincylvania
Copy link
Collaborator Author

Merging since I'm pretty happy with this and I didn't get any pushback. I'll notify translators about what's going on and give them a few days to hack away at the changes.

@quincylvania
Copy link
Collaborator Author

Here are screenshots of some of the updated sections featuring a whole bunch of new, custom icons!


Screen Shot 2020-07-13 at 2 39 13 PM


Screen Shot 2020-07-13 at 2 39 41 PM


Screen Shot 2020-07-13 at 2 40 00 PM


Screen Shot 2020-07-13 at 2 40 16 PM


Screen Shot 2020-07-13 at 2 39 32 PM

@maro-21
Copy link

maro-21 commented Jul 17, 2020

I'll notify translators about what's going on and give them a few days to hack away at the changes.

Whew, 164 strings.
Polish and Spanish are ready!
Please wait a little for German and Japanese before releasing the new version!

@quincylvania
Copy link
Collaborator Author

@maro-21 Thanks a bundle!! I'm planning to wait until Monday or so. #7786

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
walkthrough-help An issue with the walkthrough or help pane
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update documentation and walkthrough for touch interactions
2 participants