-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update help and walkthrough for touch interactions #7745
Conversation
…e in the document
Use a reusable format for the section title counts
Use keyboard styling for keys referenced in the walkthrough Add mouse icons for left/right click referenced in the walkthrough Add labels for all buttons referenced by icon in the walkthrough
Update the lines walkthrough chapter for touchscreens Add toggled dispatch event to the edit menu
So since we have to change a lot of strings anyway for touch support, it's a good opportunity for some other upgrades. I added a whole lot more placeholders so the labels in the documentation will always match the labels in the UI. The walkthrough strings now use the same placeholder list as the help pane. I also made the inline hotkey styling consistent with tooltips and the shortcuts lists. I've finished updating the walkthrough. When possible, I tried to use the same strings for both mouse and touch interactions. When interaction instructions are required, iD detects if the mapper is using touch or not. The possibility of an attached keyboard is left open. The help pane isn't done yet, but I might go ahead and merge anyway so translators can get started. |
…or in the walkthrough Only show one hotkey for closing the feature editor in the walkthrough
Use consistent close button Update a few strings
Merging since I'm pretty happy with this and I didn't get any pushback. I'll notify translators about what's going on and give them a few days to hack away at the changes. |
Whew, 164 strings. |
Closes #7692.
Creating a PR for this since the documentation is foundational and the more eyes we can get on it the better. Also, this will invalidate the translations of lots of long strings, so I'd like to get it right the first time.
My strategy for the walkthrough is only showing instructions specific to the last-used input device. I suspect most users will use the same input device throughout the entire walkthrough, but this is adaptive nonetheless.