Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn about tagging used on wrong geometry #8231

Closed
flacombe opened this issue Dec 3, 2020 · 4 comments
Closed

Warn about tagging used on wrong geometry #8231

flacombe opened this issue Dec 3, 2020 · 4 comments
Assignees
Labels
validation An issue with the validation or Q/A code
Milestone

Comments

@flacombe
Copy link

flacombe commented Dec 3, 2020

Dear maintainers,

It seems that iD currently doesn't check for tagging versus geometry used. I don't blame anyone on this, it's only an opportunity to propose something that could improve data quality and offer better guidance to iD users.
A quick look at existing issues didn't find duplicate of this problem

Some OSM tags are only valid on nodes, like barrier=block
https://wiki.openstreetmap.org/wiki/Tag:barrier%3Dblock

Using such tags on a way, area or relation should raise a warning as to encourage mappers to check documentation and change their topology.

Similar situation exist with highway=primary for instance, only valid on ways.
Using it on a node should raise a warning as well

This is related to #6779 with power=transformer and transformer=* that are only valid on nodes.
Current usage of 14 500 power=transformer and 5 800 transformer=* on ways are errors but iD users may be not aware of this.

All the best

@quincylvania quincylvania added the validation An issue with the validation or Q/A code label Dec 3, 2020
@quincylvania
Copy link
Collaborator

Sure, iD flags a few "Mismatched Geometry" situations already so it would be nice to be more encompassing.

@quincylvania quincylvania self-assigned this Dec 4, 2020
@quincylvania quincylvania added this to the 2.20.0 milestone Dec 4, 2020
@quincylvania
Copy link
Collaborator

Okay, I think I added all the remaining combinations of mismatched points/vertices/lines/areas. These might need some tweaking but will make for some useful checks.

Screen Shot 2020-12-04 at 4 26 19 PM

@flacombe
Copy link
Author

flacombe commented Dec 4, 2020

Thank you Quincy, how fast you are 👍

@quincylvania
Copy link
Collaborator

Thank you Quincy, how fast you are 👍

Sometimes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
validation An issue with the validation or Q/A code
Projects
None yet
Development

No branches or pull requests

2 participants