Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internationalize the key binding for selecting a parent way #8298

Closed
1ec5 opened this issue Jan 13, 2021 · 2 comments · Fixed by #8577
Closed

Internationalize the key binding for selecting a parent way #8298

1ec5 opened this issue Jan 13, 2021 · 2 comments · Fixed by #8577
Labels
accessibility Relates to personal ability or assistive tools keyboard An issue with keyboard navigation, shortcuts, or input localization Adapting iD across languages, regions, and cultures
Milestone

Comments

@1ec5
Copy link
Collaborator

1ec5 commented Jan 13, 2021

ddf8682 changed the key binding for selecting a parent way (#8264) from ⌘↑ to | and made it so that repeatedly pressing | would toggle between a vertex and its parent way. | makes some sense on an English QWERTY keyboard, where | is strongly associated with { and }, but it’s problematic for users of other languages and keyboard layouts. For example, among Mac keyboard layouts:

  • Belarusian, Russian, Serbian, Ukrainian – ⇧⌥1 requires three fingers
  • Croatian, Slovene – ⇧⌥Ž requires three fingers on two hands
  • French (AZERTY) – ⇧⌥L requires three fingers on two hands
  • German (QWERTZ), Finnish, Spanish – ⌥7 requires two hands and is difficult to touch-type
  • Italian, Macedonian, Norwegian, Swedish – no way to type |
  • Polish – ⌥9 requires two hands and is difficult to touch-type
  • Romanian – ⇧⌥Ț requires three fingers on two hands

⌘↑ would’ve been more universal while remaining reasonably intuitive to English speakers. It could’ve formed part of a system of arrow shortcuts for navigating “up” and “down” among nodes, ways, and relations. It would be pretty straightforward to restore ⌘↑ as an alternative key binding for |, but it wouldn’t make sense to keep the toggling behavior with ⌘↑ – it would be necessary to introduce a ⌘↓ as well. Separate ⌘↑ and ⌘↓ shortcuts would be easier to describe in help than the current | toggle.

@1ec5 1ec5 added localization Adapting iD across languages, regions, and cultures keyboard An issue with keyboard navigation, shortcuts, or input labels Jan 13, 2021
@quincylvania
Copy link
Collaborator

@1ec5 Thanks for this followup, I did read your feedback and definitely think we need to resolve this before release!

@quincylvania quincylvania added this to the 2.20.0 milestone Jan 13, 2021
@mbrzakovic mbrzakovic added the accessibility Relates to personal ability or assistive tools label Jul 13, 2021
@mbrzakovic
Copy link
Collaborator

Thanks @1ec5 on incredible descriptions, and for ensuring iD accessibility. I agree with your proposal above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Relates to personal ability or assistive tools keyboard An issue with keyboard navigation, shortcuts, or input localization Adapting iD across languages, regions, and cultures
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants