Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect validator warning: attraction=log_flume #980

Closed
nc011 opened this issue Aug 14, 2023 · 0 comments
Closed

Incorrect validator warning: attraction=log_flume #980

nc011 opened this issue Aug 14, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@nc011
Copy link

nc011 commented Aug 14, 2023

Describe the bug
When mapping a log flume as an "unclosed" way, the validator throws a warning.

"Log flume should be a closed area based on the tag attraction=log_flume"

To Reproduce

  1. Draw a way (line) - do not "close" the line (i.e. do not connect end-to-end).
  2. Tag as attraction=log_flume

Expected behavior
No warning should be thrown by the validator. As noted in the documentation, most mappers map log flumes as a linear way.

A log flume. You sit in a boat that is moved by the flow of water. Some log flume attractions feature a rapid descent and splashdown. These are often mapped as a linear way following the route of the ride.

There is no requirement for this to be a closed linear way. The boats can go up and down the same track. For example, in this instance the log flume is pulled back up the ramp via a pulley system.

Additional context
Adding the tag area=no prevents the validator warning.

@nc011 nc011 added the bug Something isn't working label Aug 14, 2023
@tyrasd tyrasd closed this as completed in fde024c Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant