Logging, Database Locking and some cleanup #53
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. Updated pgsnapshot module to include some extra logging. A little cleanup in the replication module. Using GzipInputStream implementation.
…. Updated pgsnapshot module to include some extra logging. A little cleanup in the replication module. Using GzipInputStream implementation. (#1)
…Updated PBFReader plugin to accept a URL for input.
…ks are currently set, or if you have the lockedId or not.
* Added ability in Core to Run Osmosis within a Java application easily. Updated pgsnapshot module to include some extra logging. A little cleanup in the replication module. Using GzipInputStream implementation. * Added a DatabaseLocker that can be used for any database operations. Updated PBFReader plugin to accept a URL for input. * Removing unessecary calls to unlock * Adding method to fully unlock the database regardless of how many locks are currently set, or if you have the lockedId or not.
…ocker so that if the unlock function does not exist it will skip attempting to lock, so for older databases things can work as before.
…ocker so that if the unlock function does not exist it will skip attempting to lock, so for older databases things can work as before.
* Added ability in Core to Run Osmosis within a Java application easily. Updated pgsnapshot module to include some extra logging. A little cleanup in the replication module. Using GzipInputStream implementation. * Added a DatabaseLocker that can be used for any database operations. Updated PBFReader plugin to accept a URL for input. * Removing unessecary calls to unlock * Adding method to fully unlock the database regardless of how many locks are currently set, or if you have the lockedId or not. * Adding changes sql file to the docker test scripts. Updated DatabaseLocker so that if the unlock function does not exist it will skip attempting to lock, so for older databases things can work as before. * Adding changes sql file to the docker test scripts. Updated DatabaseLocker so that if the unlock function does not exist it will skip attempting to lock, so for older databases things can work as before. * renaming schema changes file to follow convention
* Added ability in Core to Run Osmosis within a Java application easily. Updated pgsnapshot module to include some extra logging. A little cleanup in the replication module. Using GzipInputStream implementation. * Added a DatabaseLocker that can be used for any database operations. Updated PBFReader plugin to accept a URL for input. * Removing unessecary calls to unlock * Adding method to fully unlock the database regardless of how many locks are currently set, or if you have the lockedId or not. * Adding changes sql file to the docker test scripts. Updated DatabaseLocker so that if the unlock function does not exist it will skip attempting to lock, so for older databases things can work as before. * Adding changes sql file to the docker test scripts. Updated DatabaseLocker so that if the unlock function does not exist it will skip attempting to lock, so for older databases things can work as before. * renaming schema changes file to follow convention * Needed to unlock the database correctly on exceptions.
…ng a GZip stream directly through a SAX XML parser.
* Added ability in Core to Run Osmosis within a Java application easily. Updated pgsnapshot module to include some extra logging. A little cleanup in the replication module. Using GzipInputStream implementation. * Added a DatabaseLocker that can be used for any database operations. Updated PBFReader plugin to accept a URL for input. * Removing unessecary calls to unlock * Adding method to fully unlock the database regardless of how many locks are currently set, or if you have the lockedId or not. * Adding changes sql file to the docker test scripts. Updated DatabaseLocker so that if the unlock function does not exist it will skip attempting to lock, so for older databases things can work as before. * Adding changes sql file to the docker test scripts. Updated DatabaseLocker so that if the unlock function does not exist it will skip attempting to lock, so for older databases things can work as before. * renaming schema changes file to follow convention * Needed to unlock the database correctly on exceptions. * Refactored the XMLReaders, and fixed exception that occurs when running a GZip stream directly through a SAX XML parser. * Added read/write functionality into the Osmosis DatabaseLocker.
* Added ability in Core to Run Osmosis within a Java application easily. Updated pgsnapshot module to include some extra logging. A little cleanup in the replication module. Using GzipInputStream implementation. * Added a DatabaseLocker that can be used for any database operations. Updated PBFReader plugin to accept a URL for input. * Removing unessecary calls to unlock * Adding method to fully unlock the database regardless of how many locks are currently set, or if you have the lockedId or not. * Adding changes sql file to the docker test scripts. Updated DatabaseLocker so that if the unlock function does not exist it will skip attempting to lock, so for older databases things can work as before. * Adding changes sql file to the docker test scripts. Updated DatabaseLocker so that if the unlock function does not exist it will skip attempting to lock, so for older databases things can work as before. * renaming schema changes file to follow convention * Needed to unlock the database correctly on exceptions. * Refactored the XMLReaders, and fixed exception that occurs when running a GZip stream directly through a SAX XML parser. * Added read/write functionality into the Osmosis DatabaseLocker. * Adding unlock mechanism in test in a finally block.
|
Thanks Michael! There’s quite a bit here. I’m new to helping @brettch with this project so I wonder if we could break this up into a few pieces, or talk through the change as a whole? |
|
Yeah I understand it is large, so I would be happy to take some time to chat about it offline if you wish. |
|
@mgcuthbert and I connected offline, and we’ll be replacing this PR with a series of pull requests in this order:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following PR includes various changes in various components to address some specific use cases. The changes are listed below and also included in the changes.txt file.