Delete a measure, re-add it from library: no prompt and duplicated folders

[jmarrec]

System info:

• Sketchup 2016
• macOS Sierra 10.12.2
• OpenStudio 2.0.0 (47ba3cbe19)

---

There seem to be a small bug that you might have noticed too with Measures on mac (aside from not telling you it’s broken and not giving you any message that can help), where you delete a measure and re-add it from library

1. It doesn’t ask anything (no "Update all previous reference to measure?" or something)
2. You end up with a new folder named “Measure blablabla 1", as you redo that it can get quite huge

In model/measures:

[asparke2]

@jmarrec is this inside of a PAT project, an OS App model, your My Measures directory, or somewhere else?

[jmarrec]

OS App model, happen in model/measures folder

[jmarrec]

Still relevant as of 2.2.1

[crossingchen]

Hi, I'm also having this issue using v2.4.1, Windows 7 Enterprise. After deleting a measure then add back on in openstudio measure tab, in the measure folder it adds a new folder ended with those "1"s.

And if I edit the current measure.rb file (for example debugging my measure in my measure folder), synchronize with library and rerun the program, the previous error still shows in openstudio. After a couple times, I realized it is because all these previous measure files are not updated. But for whatever reason, even if i delete the measure folder, it still creates all these previous measure files ("1" ~ "1 1 1 1 1 1") when I hit run and all those previous measure files are the "old" version.

The only thing I can do to bypass this right now is to copy the osm file only and rename it, start a clean new file without any measures, then apply the updated measure.

Is there any update on this issue? Thanks.

[jmarrec]

Just reproduced this with current develop (9edf6e6a7845053047b4dfc82113e08cade23fc9, 2.6.0 basically) on Ubuntu 16.04

[jmarrec]

Check out WorkflowController.cpp#L224.

The problem is that we don't want to delete the directory from disk until the user actually saves...

[jmarrec]

Updating with permalink to this repo:

OpenStudioApplication/src/shared_gui_components/WorkflowController.cpp

Lines 184 to 207 in fd5afb7

	void MeasureStepController::removeItemForStep(MeasureStep step) {
	std::vector<MeasureStep> oldMeasureSteps = measureSteps();
	bool didRemove = false;
	std::vector<MeasureStep> newMeasureSteps;
	newMeasureSteps.reserve(oldMeasureSteps.size());
	for (const auto& oldMeasureStep : oldMeasureSteps) {
	if (oldMeasureStep == step) {
	didRemove = true;
	} else {
	newMeasureSteps.push_back(oldMeasureStep);
	}
	}
	if (didRemove) {
	// DLM: TODO actually remove the directory here, make sure it not being used by any other steps first
	// maybe want a purge unused measures in WorkflowJSON?
	// set the new steps
	m_app->currentModel()->workflowJSON().setMeasureSteps(m_measureType, newMeasureSteps);
	emit modelReset();
	}
	}