Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion: drop csslint support #932

Closed
thetric opened this issue May 19, 2020 · 3 comments
Closed

Discussion: drop csslint support #932

thetric opened this issue May 19, 2020 · 3 comments

Comments

@thetric
Copy link

thetric commented May 19, 2020

Stylus supports Stylelint and CSSLint as CSS Linter. While the former seems actively maintained (releases, contributions), CSSLint seems to be dead (no release since December 2016, no commits since February 2019, no status updates from the maintainers, older question for project status). Does it make sense to drop support for the unmaintained CSSLint?

@tophf
Copy link
Member

tophf commented May 19, 2020

We're using our own fork of CSSLint. You can report issues with csslint in this repo, but first search for an existing report.

@tophf tophf closed this as completed May 19, 2020
@eight04
Copy link
Collaborator

eight04 commented May 20, 2020

We are still using the parser from CSSLint to parse the code so it can't be dropped directly. Do stylelint have a parser? I've heard that it uses postcss under the hood but I never learn how it works.

@tophf
Copy link
Member

tophf commented May 20, 2020

Even if we won't use csslint's parser, our fork of csslint itself is useful for standard CSS because it's several times faster than stylelint and provides a minimum level of linting to prevent typos or to check parentheses and other basic stuff. Actually, if I weren't so lazy I would add the ability to check stylus/less syntax to our csslint and then try to convince everyone to get rid of stylelint.

Edit: turns out our csslint can be 10+ times faster than stylelint thanks to reusing the previous run's results so continuously making trivial edits (typing, changing colors) in GitHub-Dark usercss will take ~600ms in stylelint (blergh) but only ~60ms in csslint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants