Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI should be able to run with or without TLS #131

Closed
jakedoublev opened this issue Apr 25, 2024 · 1 comment
Closed

CLI should be able to run with or without TLS #131

jakedoublev opened this issue Apr 25, 2024 · 1 comment

Comments

@jakedoublev
Copy link
Contributor

jakedoublev commented Apr 25, 2024

Background

The CLI is currently hardcoded to run without a secure TLS connection and to dial http://localhost:<port>. The platform TLS story is maturing1 and once it is stabilized within the SDK, the CLI should support the ability to drive with or without TLS so it can successfully dial the platform port in either scenario.

Acceptance Criteria

  1. CLI does not hardcode http platform endpoints
  2. CLI's SDK initializations include the sdk.WithInsecureConnection() option only when running without TLS enabled
  3. config is updated to include a TLS enabled true/false flag
  4. the config subcommand is updated to drive the TLS enabled state and update the config when ran
  5. the error message with code Unavailable and desc "connection error" is transformed into a more helpful error message to the user like "Failed to dial the platform, please check that it is running on ".

Footnotes

  1. https://github.com/opentdf/platform/issues/451

@jrschumacher
Copy link
Member

This was completed with #152

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants