Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add environment variables for global flags #348

Open
jrschumacher opened this issue Aug 29, 2024 · 0 comments
Open

Add environment variables for global flags #348

jrschumacher opened this issue Aug 29, 2024 · 0 comments

Comments

@jrschumacher
Copy link
Member

jrschumacher commented Aug 29, 2024

Feedback from users regarding use of CLI

Supporting env + global flags + profiles and allowing the blending of all of them creates too much burden on the team to reliably test all permutations. We would like to strictly enforce supporting only specified set of triggers.

So...

  • read global flags
    • if user does not meet required flag shape then return error, DO NOT fill in with env or profiles
  • read env next
    • with using env we will require a flag --use-env
    • when this flag is specified, we will ONLY use the environment variables and return an error if shape isn't met
    • we will only support client credentials
  • default to profiles
    • will still defer Linux support for now
    • if on Linux, will require global flags or env

Acceptance Criteria

  • follow rules above
  • use the following env vars
    • {APP_NAME}_HOST
    • {APP_NAME}_TLS_NO_VERIFY
    • {APP_NAME}_CLIENT_CREDS
    • {APP_NAME}_CLIENT_CREDS_FILE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant