Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NewHandler should be cleaned up #383

Open
jakedoublev opened this issue Sep 12, 2024 · 0 comments
Open

NewHandler should be cleaned up #383

jakedoublev opened this issue Sep 12, 2024 · 0 comments

Comments

@jakedoublev
Copy link
Contributor

Background

The cmd package has a helper function NewHandler that does a lot of setup work for every command: https://github.com/opentdf/otdfctl/blob/main/cmd/root.go#L72

There is quite a bit of complexity in nested if statements, and it should be explored if it can be a preRun hook

Acceptance Criteria

  1. nested if complexity is reduced
  2. exploration about a preRun hook on every command that needs a handler available to it
  3. unit tests as appropriate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant