Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ci): add tests for subject condition sets, and --force delete flag #389

Merged
merged 3 commits into from
Oct 1, 2024
Merged

feat(ci): add tests for subject condition sets, and --force delete flag #389

merged 3 commits into from
Oct 1, 2024

Conversation

jakedoublev
Copy link
Contributor

Resolves #331

@jakedoublev jakedoublev requested a review from a team as a code owner September 17, 2024 20:22
ryanulit
ryanulit reviewed Oct 1, 2024
View reviewed changes
Copy link
Contributor

@ryanulit ryanulit left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but maybe add a test for the force flag as well?

nevermind, just noticed the delete method uses it...will approve

@jakedoublev jakedoublev merged commit c6d2abc into main Oct 1, 2024
7 checks passed
@jakedoublev jakedoublev deleted the feat/scs-tests branch October 1, 2024 14:21
@opentdf-automation opentdf-automation bot mentioned this pull request Oct 1, 2024
Merged
jakedoublev pushed a commit that referenced this pull request Oct 1, 2024
@opentdf-automation
chore(main): release 0.14.0 (#385)
c7eafb9 
🤖 I have created a release *beep* *boop*
---


##
[0.14.0](v0.13.0...v0.14.0)
(2024-10-01)


### Features

* **ci:** add e2e tests for subject mappings, support for --force delete
([#388](#388))
([c1f544b](c1f544b))
* **ci:** add tests for subject condition sets, and --force delete flag
([#389](#389))
([c6d2abc](c6d2abc)),
closes [#331](#331)
* **ci:** e2e attribute definitions tests
([#384](#384))
([2894391](2894391)),
closes [#327](#327)
* **core:** export manual functions for CLI wrappers to consume
([#397](#397))
([aa0bf95](aa0bf95))
* **core:** resource mappings LIST fix, delete --force support, and e2e
tests ([#387](#387))
([326e74b](326e74b)),
closes [#386](#386)


### Bug Fixes

* **core:** remove duplicate titling of help manual
([#391](#391))
([cb8db69](cb8db69))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanulit ryanulit ryanulit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test e2e: subject condition sets
2 participants
@jakedoublev @ryanulit