feat(core): Update Resource Mapping delete to use get before delete for cli output #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakedoublev
approved these changes
Oct 2, 2024
jakedoublev
pushed a commit
that referenced
this pull request
Oct 15, 2024
🤖 I have created a release *beep* *boop* --- ## [0.15.0](v0.14.0...v0.15.0) (2024-10-15) ### Features * **core:** DSP-51 - deprecate PublicKey local field ([#400](#400)) ([1955800](1955800)) * **core:** Update Resource Mapping delete to use get before delete for cli output ([#398](#398)) ([79f2a42](79f2a42)) ### Bug Fixes * **core:** build with latest opentdf releases ([#404](#404)) ([969b82b](969b82b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to changes made in opentdf/platform#1422 to only return an object with the ID for delete operations, we need to update the otdfctl Resource Mapping delete operation to make a Get request from the DB before deletion of the record. The object returned from the Get is then used for the user-friendly CLI output of the whole object.