From 9db9862fdd2f1155a2694f7f835bb808ca1df70c Mon Sep 17 00:00:00 2001 From: jakedoublev Date: Thu, 22 Aug 2024 08:36:42 -0700 Subject: [PATCH 1/2] fix(core): nil panic on set-default --- cmd/profile.go | 3 +++ pkg/profiles/profile.go | 10 +++++++--- 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/cmd/profile.go b/cmd/profile.go index bfdb2cdc..918c081d 100644 --- a/cmd/profile.go +++ b/cmd/profile.go @@ -125,6 +125,9 @@ var profileSetDefaultCmd = &cobra.Command{ Short: "Set a profile as default", Args: cobra.ExactArgs(1), Run: func(cmd *cobra.Command, args []string) { + // ensure profile is initialized + InitProfile(cmd, false) + profileName := args[0] print := cli.NewPrinter(true) diff --git a/pkg/profiles/profile.go b/pkg/profiles/profile.go index 0bb995b6..110e3ca0 100644 --- a/pkg/profiles/profile.go +++ b/pkg/profiles/profile.go @@ -2,6 +2,7 @@ package profiles import ( "errors" + "fmt" ) // TODO: @@ -30,9 +31,11 @@ type CurrentProfileStore struct { config ProfileConfig } -const PROFILE_DRIVER_KEYRING = "keyring" -const PROFILE_DRIVER_IN_MEMORY = "in-memory" -const PROFILE_DRIVER_DEFAULT = PROFILE_DRIVER_KEYRING +const ( + PROFILE_DRIVER_KEYRING = "keyring" + PROFILE_DRIVER_IN_MEMORY = "in-memory" + PROFILE_DRIVER_DEFAULT = PROFILE_DRIVER_KEYRING +) type profileConfigVariadicFunc func(profileConfig) profileConfig @@ -169,6 +172,7 @@ func (p *Profile) UseDefaultProfile() (*ProfileStore, error) { } func (p *Profile) SetDefaultProfile(profileName string) error { + fmt.Println(p) if !p.globalStore.ProfileExists(profileName) { return errors.New("profile does not exist") } From 39cdb6aa54ae5f9b70353caf49a66049c6fd3e44 Mon Sep 17 00:00:00 2001 From: Jake Van Vorhis <83739412+jakedoublev@users.noreply.github.com> Date: Thu, 22 Aug 2024 08:38:15 -0700 Subject: [PATCH 2/2] Update pkg/profiles/profile.go Co-authored-by: Ryan Schumacher --- pkg/profiles/profile.go | 1 - 1 file changed, 1 deletion(-) diff --git a/pkg/profiles/profile.go b/pkg/profiles/profile.go index 110e3ca0..05932038 100644 --- a/pkg/profiles/profile.go +++ b/pkg/profiles/profile.go @@ -172,7 +172,6 @@ func (p *Profile) UseDefaultProfile() (*ProfileStore, error) { } func (p *Profile) SetDefaultProfile(profileName string) error { - fmt.Println(p) if !p.globalStore.ProfileExists(profileName) { return errors.New("profile does not exist") }