New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

review our proto validate implementation #1057

Open

strantalis opened this issue Jun 28, 2024 · 1 comment · May be fixed by #1231

Member

strantalis commented Jun 28, 2024

We should take a look at our protos and see where we can add more validation.

Example is requiring an entity type in the following oneOf

platform/service/authorization/authorization.proto

Lines 20 to 28 in 8193cec

    
           oneof entity_type { 
        
             string email_address = 2; 
        
             string user_name = 3; 
        
             string remote_claims_url = 4; 
        
             string uuid = 5; 
        
             google.protobuf.Any claims = 6; 
        
             EntityCustom custom = 7; 
        
             string client_id = 8; 
        
           }

https://github.com/bufbuild/protoc-gen-validate/tree/main?tab=readme-ov-file#oneofs

Member Author

strantalis commented Jun 28, 2024

Will help protect us from this issue #1055

elizabethhealy linked a pull request

that will close this issue

feat(authz): Add proto validation on oneOf entity_type #1231

Draft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment