Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): re-run on description or title change #1278

Merged
merged 9 commits into from
Aug 12, 2024

Conversation

strantalis
Copy link
Member

@strantalis strantalis commented Aug 7, 2024

I ended up splitting out the pull request validation jobs into a separate workflows. It was getting confusing mixing code related checks and non code checks in one workflow.

resolves: #1279

@strantalis strantalis requested review from a team as code owners August 7, 2024 19:04
@strantalis strantalis marked this pull request as draft August 7, 2024 19:10
jakedoublev
jakedoublev previously approved these changes Aug 7, 2024
@strantalis strantalis marked this pull request as ready for review August 9, 2024 12:00
Copy link
Member

@dmihalcik-virtru dmihalcik-virtru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor note about removing an an unneeded job

.github/workflows/pr-checks.yaml Outdated Show resolved Hide resolved
.github/workflows/checks.yaml Show resolved Hide resolved
@strantalis strantalis added this pull request to the merge queue Aug 9, 2024
@strantalis strantalis removed this pull request from the merge queue due to a manual request Aug 9, 2024
jrschumacher
jrschumacher previously approved these changes Aug 9, 2024
@strantalis strantalis added this pull request to the merge queue Aug 9, 2024
@strantalis strantalis removed this pull request from the merge queue due to a manual request Aug 9, 2024
.github/workflows/checks.yaml Show resolved Hide resolved
.github/workflows/pr-checks.yaml Outdated Show resolved Hide resolved
pflynn-virtru
pflynn-virtru previously approved these changes Aug 9, 2024
.github/workflows/pr-checks.yaml Outdated Show resolved Hide resolved
biscoe916
biscoe916 previously approved these changes Aug 12, 2024
@strantalis strantalis dismissed dmihalcik-virtru’s stale review August 12, 2024 18:18

@dmilhalcik-virtru and I synced. We are good here and will continue to improve our ci story.

@strantalis strantalis added this pull request to the merge queue Aug 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 12, 2024
@strantalis strantalis added this pull request to the merge queue Aug 12, 2024
Merged via the queue into opentdf:main with commit 7d980cc Aug 12, 2024
19 checks passed
@strantalis strantalis deleted the re-run-on-description-change branch August 12, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

re-run ci on certain pr validation checks on
6 participants