-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
localnet improvement #802
Open
open-junius
wants to merge
15
commits into
devnet-ready
Choose a base branch
from
junius/feat-localnet-improve
base: devnet-ready
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
localnet improvement #802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sam0x17
previously approved these changes
Sep 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! ran locally and was easy to configure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The feature will improve the localnet configuration for testing.
tasks
REQ-LOCNET-001: Configure "pow-faucet" feature for registrations
Enable the "pow-faucet" feature for the Localnet configuration.
This feature should be used to manage registrations in the Localnet environment.
REQ-LOCNET-002: Set initial max registrations per block to 1000
Update the SubtensorInitialMaxRegistrationsPerBlock constant to 1000.
This should only apply when the "pow-faucet" feature is enabled.
REQ-LOCNET-003: Set initial target registrations per interval to 1000
Update the SubtensorInitialTargetRegistrationsPerInterval constant to 1000.
This should only apply when the "pow-faucet" feature is enabled.
REQ-LOCNET-004: Create subnet 1
Not in subtensor side, we will use btcli to create.
REQ-LOCNET-005: Remove subnet 3
Subnet 3 should not be present in the Localnet configuration.
Any references or dependencies on subnet 3 should be removed from the Localnet codebase.
REQ-LOCNET-006: Create predefined accounts with specific roles
Not in subtensor side, we will use btcli to create. And pre-defined accounts are the same as balances.
REQ-LOCNET-007: Set specific TAO balances for predefined accounts
pre-defined accounts are the same as balances in local chain setting.
REQ-LOCNET-008: Implement account creation and balance setting on Localnet initialization
Related Issue(s)
Type of Change
Breaking Change
If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.
Checklist
cargo fmt
andcargo clippy
to ensure my code is formatted and linted correctlyScreenshots (if applicable)
Please include any relevant screenshots or GIFs that demonstrate the changes made.
Additional Notes
Please provide any additional information or context that may be helpful for reviewers.