Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix potential crash in Player::getClientIcons #136

Conversation

beats-dh
Copy link
Collaborator

@beats-dh beats-dh commented Oct 7, 2021

Description

Fixes a potential crash by checking if tile is not a null pointer in Player::getClientIcons.

Co-Authored-By: @dbjorkholm.

Behaviour

Actual

Do this and that doesn't happens

Expected

Do this and that happens

Fixes

# (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Server Version:
  • Client:
  • Operating System:

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Co-Authored-By: Schiffers 10325310+Schiffers@users.noreply.github.com

…Player::getClientIcons function

Co-Authored-By: Schiffers <10325310+Schiffers@users.noreply.github.com>
…e-is-not-a-null-pointer-in-Player-getClientIcons-function
beats-dh and others added 2 commits October 27, 2021 23:47
…e-is-not-a-null-pointer-in-Player-getClientIcons-function
…e-is-not-a-null-pointer-in-Player-getClientIcons-function
@majestyotbr majestyotbr changed the title Fixes a potential crash by checking if tile is not a null pointer in … Fixes a potential crash by checking if tile is not a null pointer in Player::getClientIcons function Nov 3, 2021
@sonarcloud
Copy link

sonarcloud bot commented Nov 3, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@majestyotbr majestyotbr changed the title Fixes a potential crash by checking if tile is not a null pointer in Player::getClientIcons function Fix potential crash in Player::getClientIcons Nov 3, 2021
@majestyotbr majestyotbr merged commit 4422dbc into opentibiabr:master Nov 3, 2021
@beats-dh beats-dh deleted the Fixes-a-potential-crash-by-checking-if-tile-is-not-a-null-pointer-in-Player-getClientIcons-function branch November 6, 2021 20:25
luan pushed a commit that referenced this pull request Jul 11, 2023
Fixes a potential crash by checking if tile is not a null pointer in Player::getClientIcons.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants