Fix supply stash exploit #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dudantas
approved these changes
Aug 26, 2021
|
Kudos, SonarCloud Quality Gate passed!
|
2 tasks
5 tasks
10 tasks
1 task
luan
pushed a commit
that referenced
this pull request
Jul 11, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Without this check, one could just send packets to stow/withdraw items while hunting and it would work. You wouldn't have to be in depo or anywhere near it to make it work.
Behaviour
Actual:
You can stow/withdraw an item while not standing on depo tile.
Expected:
You should receive error message when trying to stow/withdraw item from stash while not standing on depo tile.
Credits:
@Oen44
https://github.com/opentibiabr/otservbr-global/pull/2662