Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: some scripts #1821

Merged
merged 29 commits into from
Nov 28, 2023
Merged

fix: some scripts #1821

merged 29 commits into from
Nov 28, 2023

Conversation

elsongabriel
Copy link
Contributor

@elsongabriel elsongabriel commented Nov 14, 2023 •
edited
Loading

Description

Continues fixing of #1784 and #1847

  • Improved message on exercise_training;
  • Fixes reward charges;
  • Created flag in prison bosses' scripts to enable minus players and removed already created functions;
  • Removed create torch when player login;
  • Fixes in 'clearBossRoom' function usage on bosses teleports;
  • Fixed cask_kegs (undo the last pr);
  • Fixed count days and time on ferumbras_lever and fixed mechanic of Ascending Ferumbras boss.
  • Fixed xp boost storage resetter (on very ss, the storage was being presented, and the player always buy it with 30 tc);
  • Fixed firewalker boots transform with 'worn leather boots' and a small enchanted ruby;
  • Added 13.21 new mounts, reordered and fixed typos, changed the word moveable to movable (grammarist link);
  • Removed unnecessary spaces;

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested

Test Configuration:

  • Server Version: Canary 3.1.1
  • Client: Tibia 13.21
  • Operating System: Windows/Ubuntu

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@elsongabriel elsongabriel mentioned this pull request Nov 15, 2023
Closed
5 tasks
@elsongabriel elsongabriel marked this pull request as draft November 18, 2023 04:11
@elsongabriel elsongabriel marked this pull request as ready for review November 19, 2023 09:52
elsongabriel and others added 12 commits November 19, 2023 23:15
@elsongabriel
exercise_training: improved msg.
44a8014 
broadcast: removed unnecessary Webhook.sendMessage.
reward: fixes charges.
prision bosses: created flag to enable minus players. removed functions already created.
login: removed create torch when player login.
bosses teleports: fixes in 'clearBossRoom' function usage.
@elsongabriel
cask_kegs: redo.
d7f69a4
@elsongabriel
xp boost: removed the reset of xp boost storage on server save. (on e…
41576b7 
…very ss, the xp boost storage was cleaned)
@elsongabriel
firewalker boots transform: removed 'worn leather boots' to transform…
fa46072 
…ing when uses small enchanted ruby.
@elsongabriel
gamestore & mounts: added 13.21 new mounts, reordered and fixed typos…
6dbe55b 
…, changed the word moveable to movable (https://grammarist.com/spelling/movable-moveable/#:~:text=Moveable%20is%20the%20older%20spelling,so%20for%20over%20a%20century.)
@elsongabriel
npc: added npc name in logs.
9f62539
@elsongabriel
typo in movable: fixed typos, changed the word moveable to movable (h…
a2e755c 
…ttps://grammarist.com/spelling/movable-moveable/#:~:text=Moveable%20is%20the%20older%20spelling,so%20for%20over%20a%20century.)
@elsongabriel
quests: removed unnecessary spaces.
45c73aa 
broadcast: undo removed commented (Webhook.sendMessage) on broadcast, to resolve in further problems with encoding.
@elsongabriel
adjusted scripts.
d79d704
@elsongabriel
reward: added message on reward item.
ebd39c5
@elsongabriel
player.lua: removed unused function.
f35a3b5 
ferumbras_lever: fixed script and your summons creation.
soul war mount: created function to gives to the player the mount.
otservbr-custom-zones.xml: added to repository.
@github-actions @elsongabriel
Lua code format - (Stylua)
db0f01c
elsongabriel and others added 8 commits November 25, 2023 09:09
@elsongabriel
Merge branch 'main' into hotfix/fix-scripts
5c45a9d
@elsongabriel @dudantas
Edu suggestion.
caf1d8c 
Co-authored-by: Eduardo Dantas <eduardo.dantas@hotmail.com.br>
@elsongabriel @dudantas
Edu suggestion.
c3576a5 
Co-authored-by: Eduardo Dantas <eduardo.dantas@hotmail.com.br>
@elsongabriel @dudantas
Edu suggestion.
0edd09a 
Co-authored-by: Eduardo Dantas <eduardo.dantas@hotmail.com.br>
@elsongabriel
Re-added function.
e6017d1 
Moved global config to a register lib.
@elsongabriel
Fix vortex.
3f57f48
@github-actions
Lua code format - (Stylua)
1383437
@elsongabriel
Merge branch 'main' into hotfix/fix-scripts
1a51f71
@dudantas dudantas merged commit 83a823f into opentibiabr:main Nov 28, 2023
10 checks passed
@elsongabriel elsongabriel deleted the hotfix/fix-scripts branch November 28, 2023 12:21
@dudantas dudantas mentioned this pull request Nov 28, 2023
Merged
dudantas added a commit that referenced this pull request Nov 28, 2023
@dudantas
fix: invalid mount offer from store (#1933)
f4bb861 
Fixes bug introduced from #1821 

A mount was added that does not yet exist in appearances, until we add a new dat, we will just ignore their existence.
Removed invalid mounts.
@macvirii
Copy link
Contributor

macvirii commented Dec 9, 2023

I really like the /tp solution of this PR. But I still think there should be a way to remove the TP too... Or am I being unreasonable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luanluciano93 luanluciano93 luanluciano93 left review comments

@luan luan luan left review comments

@dudantas dudantas dudantas approved these changes

Assignees
No one assigned
Labels
Area: Datapack Canary Area: Datapack Core Area: Datapack Global Area: Map Global
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@elsongabriel @macvirii @luan @luanluciano93 @dudantas